Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 514603002: Let omnibox Depend on variations_http_provider instead of variations (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Let omnibox Depend on variations_http_provider instead of variations Depend on the correct target BUG=388515 Committed: https://crrev.com/03080906fada022d738ade0b304d1be287804a5f Cr-Commit-Position: refs/heads/master@{#292316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M components/omnibox.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M components/omnibox/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
hashimoto@chromium.org changed reviewers: + pkasting@chromium.org
6 years, 3 months ago (2014-08-27 11:21:45 UTC) #1
hashimoto
6 years, 3 months ago (2014-08-27 11:21:45 UTC) #2
Peter Kasting
RS LGTM
6 years, 3 months ago (2014-08-27 19:46:19 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 3 months ago (2014-08-28 03:13:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/514603002/1
6 years, 3 months ago (2014-08-28 03:15:19 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 03:54:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 03830bdd9e597948bcc285b2f88db623c4b5513b
6 years, 3 months ago (2014-08-28 04:20:13 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03080906fada022d738ade0b304d1be287804a5f
Cr-Commit-Position: refs/heads/master@{#292316}

Powered by Google App Engine
This is Rietveld 408576698