Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 514583002: Use SearchProvider for Athena (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use SearchProvider for Athena With SearchProvider, we can suggest URLs as well as queries and show icons at the left of each suggested item. Also, parts of the suggested query which is not typed by the user are shown bold. Basically do the same thing as Chrome's AutocompleteController+OmniboxProvider. Add required resources to athena_resources. BUG=408050 Committed: https://crrev.com/558552c08aa33abdabd0e874097a851f65986e29 Cr-Commit-Position: refs/heads/master@{#292350}

Patch Set 1 : #

Total comments: 3

Patch Set 2 : rebase #

Patch Set 3 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -124 lines) Patch
M athena/main/url_search_provider.h View 3 chunks +7 lines, -8 lines 0 comments Download
M athena/main/url_search_provider.cc View 1 2 5 chunks +149 lines, -116 lines 0 comments Download
M athena/resources/athena_resources.gyp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-27 11:01:59 UTC) #1
hashimoto
hashimoto@chromium.org changed reviewers: + mukai@chromium.org
6 years, 3 months ago (2014-08-27 11:24:25 UTC) #2
hashimoto
https://codereview.chromium.org/514583002/diff/20001/components/omnibox.gypi File components/omnibox.gypi (right): https://codereview.chromium.org/514583002/diff/20001/components/omnibox.gypi#newcode22 components/omnibox.gypi:22: 'variations_http_provider', This dependency fix will be fixed in https://codereview.chromium.org/514603002/
6 years, 3 months ago (2014-08-27 11:24:25 UTC) #3
Jun Mukai
lgtm https://codereview.chromium.org/514583002/diff/20001/athena/main/url_search_provider.cc File athena/main/url_search_provider.cc (right): https://codereview.chromium.org/514583002/diff/20001/athena/main/url_search_provider.cc#newcode91 athena/main/url_search_provider.cc:91: return "en-US"; Can you put a TODO comment ...
6 years, 3 months ago (2014-08-27 17:03:20 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 3 months ago (2014-08-28 06:30:01 UTC) #5
hashimoto
https://codereview.chromium.org/514583002/diff/20001/athena/main/url_search_provider.cc File athena/main/url_search_provider.cc (right): https://codereview.chromium.org/514583002/diff/20001/athena/main/url_search_provider.cc#newcode91 athena/main/url_search_provider.cc:91: return "en-US"; On 2014/08/27 17:03:20, Jun Mukai wrote: > ...
6 years, 3 months ago (2014-08-28 06:30:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/514583002/60001
6 years, 3 months ago (2014-08-28 06:30:52 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 08:03:04 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001) as b337b8d78a65deea68f0a32063ab9e278d0118bd
6 years, 3 months ago (2014-08-28 08:48:08 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:32 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/558552c08aa33abdabd0e874097a851f65986e29
Cr-Commit-Position: refs/heads/master@{#292350}

Powered by Google App Engine
This is Rietveld 408576698