Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 514573002: Track empty username and password in PasswordStore. (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Track empty username and password in PasswordStore. Having both username and password empty is incorrect. We should find out where they come from. BUG=404012 Committed: https://crrev.com/0ae57a5355e1c95ca53861b06a330d690b94fd11 Cr-Commit-Position: refs/heads/master@{#292135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M components/password_manager/core/browser/password_store.cc View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vasilii
vasilii@chromium.org changed reviewers: + vabr@chromium.org
6 years, 3 months ago (2014-08-27 10:48:16 UTC) #1
vasilii
please check that one too as a follow-up.
6 years, 3 months ago (2014-08-27 10:48:16 UTC) #2
vabr (Chromium)
LGTM. Also, thanks for explaining. Just for the record if anybody else wonders why landing ...
6 years, 3 months ago (2014-08-27 10:57:40 UTC) #3
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 3 months ago (2014-08-27 11:08:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/514573002/1
6 years, 3 months ago (2014-08-27 11:09:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as fddf0096cf70c7bff00b460ed50dccdc0e2b5652
6 years, 3 months ago (2014-08-27 11:56:58 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ae57a5355e1c95ca53861b06a330d690b94fd11
Cr-Commit-Position: refs/heads/master@{#292135}

Powered by Google App Engine
This is Rietveld 408576698