Issue 51453003: Fix some warnings on gcc 4.7 on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51453003: Fix some warnings on gcc 4.7 on Linux. (Closed)

Created:
7 years, 1 month ago by lgombos

Modified:
7 years, 1 month ago

Reviewers:
Nico, Jói

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
	M	chrome/browser/devtools/devtools_adb_bridge_browsertest.cc	View		2 chunks	+18 lines, -11 lines	0 comments	Download
	M	google_apis/gcm/engine/connection_handler_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

lgombos

joi@chromium.org: Please review changes in google_apis/gcm/engine/connection_handler_unittest.cc

7 years, 1 month ago (2013-10-29 22:35:35 UTC) #2

Jói

LGTM On Tue, Oct 29, 2013 at 10:38 PM, <thakis@chromium.org> wrote: > lgtm > > ...

7 years, 1 month ago (2013-10-30 10:36:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/51453003/1

7 years, 1 month ago (2013-10-30 11:54:59 UTC) #5

Message was sent while issue was closed.

Change committed as 231828