Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: chrome/browser/resources/options/search_page.js

Issue 514503002: Clean up cr.ui.pageManager.Page prototype (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/font_settings.js ('k') | ui/webui/resources/js/cr/ui/page_manager/page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/search_page.js
diff --git a/chrome/browser/resources/options/search_page.js b/chrome/browser/resources/options/search_page.js
index 15042bf3721485273340a57d45eed741d92edd10..27cd9a53e704da5b3e2c0046fb59ce78c92e8934 100644
--- a/chrome/browser/resources/options/search_page.js
+++ b/chrome/browser/resources/options/search_page.js
@@ -164,13 +164,11 @@ cr.define('options', function() {
return true;
},
- /**
- * Called after this page has shown.
- */
+ /** @override */
didShowPage: function() {
- // This method is called by the Options page after all pages have
- // had their visibilty attribute set. At this point we can perform the
- // search specific DOM manipulation.
+ // This method is called by the PageManager after all pages have had their
+ // visibility attribute set. At this point we can perform the
+ // search-specific DOM manipulation.
this.setSearchActive_(true);
},
@@ -179,14 +177,11 @@ cr.define('options', function() {
this.setSearchActive_(true);
},
- /**
- * Called before this page will be hidden.
- */
+ /** @override */
willHidePage: function() {
- // This method is called by the Options page before all pages have
- // their visibilty attribute set. Before that happens, we need to
- // undo the search specific DOM manipulation that was performed in
- // didShowPage.
+ // This method is called by the PageManager before all pages have their
+ // visibility attribute set. Before that happens, we need to undo the
+ // search-specific DOM manipulation that was performed in didShowPage.
this.setSearchActive_(false);
},
« no previous file with comments | « chrome/browser/resources/options/font_settings.js ('k') | ui/webui/resources/js/cr/ui/page_manager/page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698