Clean up cr.ui.pageManager.Page prototype

chrome/browser/resources/options/chromeos/change_picture_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var UserImagesGrid = options.UserImagesGrid;
   var ButtonImages = UserImagesGrid.ButtonImages;
 
@@ skipping 86 matching lines @@
 
       // Old user image data (if present).
       this.oldImage_ = null;
 
       $('change-picture-overlay-confirm').addEventListener(
           'click', this.closeOverlay_.bind(this));
 
       chrome.send('onChangePicturePageInitialized');
     },
 
-    /**
-     * Called right after the page has been shown to user.
-     */
+    /** @override */
     didShowPage: function() {
       var imageGrid = $('user-image-grid');
       // Reset camera element.
       imageGrid.cameraImage = null;
       imageGrid.updateAndFocus();
       chrome.send('onChangePicturePageShown');
     },
 
-    /**
-     * Called right before the page is hidden.
-     */
+    /** @override */
     willHidePage: function() {
       var imageGrid = $('user-image-grid');
       imageGrid.blur();  // Make sure the image grid is not active.
       imageGrid.stopCamera();
       if (this.oldImage_) {
         imageGrid.removeItem(this.oldImage_);
         this.oldImage_ = null;
       }
       chrome.send('onChangePicturePageHidden');
     },
 
     /**
-     * Called right after the page has been hidden.
+     * Either willHidePage or didClosePage may be called depending on the way
+     * the page was closed.
+     * @override
      */
-    // TODO(ivankr): both callbacks are required as only one of them is called
-    // depending on the way the page was closed, see http://crbug.com/118923.
     didClosePage: function() {
       this.willHidePage();
     },
 
     /**
      * Closes the overlay, returning to the main settings page.
      * @private
      */
     closeOverlay_: function() {
       if (!$('change-picture-page').hidden)
@@ skipping 185 matching lines @@
     'setProfileImage',
     'setSelectedImage',
   ]);
 
   // Export
   return {
     ChangePictureOptions: ChangePictureOptions
   };
 
 });