Issue 514493004: Revert of Adding Select Action Bar Unit test case for input (patchset #3 of https://codereview.chro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 514493004: Revert of Adding Select Action Bar Unit test case for input (patchset #3 of https://codereview.chro… (Closed)

Created:
6 years, 3 months ago by awong

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Committed: https://crrev.com/80b00e579d615035a2693ed5a16fe4576671841c Cr-Commit-Position: refs/heads/master@{#292276}

Patch Set 1 #

Patch Set 2 : copying #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -68 lines)			Patch
M	chrome/browser/extensions/api/chrome_extensions_api_client.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/chrome_extensions_api_client.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	device/hid/hid_connection_unittest.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	device/hid/hid_service.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	device/hid/hid_service.cc	View	1	2 chunks	+6 lines, -45 lines	0 comments	Download
M	device/hid/hid_service_unittest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	extensions/browser/api/extensions_api_client.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	extensions/browser/api/extensions_api_client.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	extensions/browser/api/hid/hid_api.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	extensions/browser/api/hid/hid_device_manager.h	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	extensions/browser/api/hid/hid_device_manager.cc	View	1	5 chunks	+5 lines, -8 lines	0 comments	Download
M	extensions/shell/app_shell.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	extensions/shell/browser/api/shell_extensions_api_client.h	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	extensions/shell/browser/api/shell_extensions_api_client.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	extensions/shell/browser/shell_extensions_browser_client.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

Committed patchset #2 to pending queue manually as 3db4025 (tree was closed).

6 years, 3 months ago (2014-08-28 00:25:50 UTC) #1

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:55:55 UTC) #2

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/80b00e579d615035a2693ed5a16fe4576671841c
Cr-Commit-Position: refs/heads/master@{#292276}

Expand Messages | Collapse Messages