chrome/browser/chromeos/status/data_promo_notification.cc - Issue 514493002: Cleanup: Remove unneeded grit include in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/status/data_promo_notification.cc

Issue 514493002: Cleanup: Remove unneeded grit include in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@grit_clean_chromium_strings_401588_a

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/options/wimax_config_view.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/third_party/mozilla_security_manager/nsNSSCertificate.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/status/data_promo_notification.cc

diff --git a/chrome/browser/chromeos/status/data_promo_notification.cc b/chrome/browser/chromeos/status/data_promo_notification.cc

index 9471e5c30b44f11602602099cb5aefa59193dd7a..0985b5d58bc8d610cbd91b67b1dccd26f16b1ca6 100644

--- a/chrome/browser/chromeos/status/data_promo_notification.cc

+++ b/chrome/browser/chromeos/status/data_promo_notification.cc

@@ -21,7 +21,6 @@

#include "chrome/browser/ui/singleton_tabs.h"

#include "chrome/common/pref_names.h"

#include "chrome/grit/generated_resources.h"

-#include "chrome/grit/theme_resources.h"

#include "chromeos/login/login_state.h"

#include "chromeos/network/device_state.h"

#include "chromeos/network/network_connection_handler.h"

@@ -187,7 +186,8 @@ void DataPromoNotification::ShowOptionalMobileDataPromoNotification() {

if (carrier)

deal = GetCarrierDeal(carrier);

- base::string16 message = l10n_util::GetStringUTF16(IDS_3G_NOTIFICATION_MESSAGE);

+ base::string16 message =

+ l10n_util::GetStringUTF16(IDS_3G_NOTIFICATION_MESSAGE);

std::string info_url;

if (deal) {

carrier_deal_promo_pref = GetCarrierDealPromoShown();