Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: chrome/browser/component_updater/test/component_updater_service_unittest.cc

Issue 514473002: Componentize component_updater: Break content/ dependency for rest of component_updater tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix lint issues. fix explicits. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/component_updater/test/component_patcher_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/test/component_updater_service_unittest.cc
diff --git a/chrome/browser/component_updater/test/component_updater_service_unittest.cc b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
index ab70d8bd709dc2234683347af441bb58fe121b05..b52777c7994a48e7b63f14bee28c561dfb26127c 100644
--- a/chrome/browser/component_updater/test/component_updater_service_unittest.cc
+++ b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
@@ -44,10 +44,16 @@ MockServiceObserver::~MockServiceObserver() {
}
ComponentUpdaterTest::ComponentUpdaterTest()
- : test_config_(NULL),
+ : post_interceptor_(NULL),
+ test_config_(NULL),
thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {
// The component updater instance under test.
- test_config_ = new TestConfigurator;
+ test_config_ = new TestConfigurator(
+ BrowserThread::GetBlockingPool()
+ ->GetSequencedTaskRunnerWithShutdownBehavior(
+ BrowserThread::GetBlockingPool()->GetSequenceToken(),
+ base::SequencedWorkerPool::SKIP_ON_SHUTDOWN),
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO));
component_updater_.reset(ComponentUpdateServiceFactory(test_config_));
net::URLFetcher::SetEnableInterceptionForTests(true);
@@ -59,7 +65,8 @@ ComponentUpdaterTest::~ComponentUpdaterTest() {
void ComponentUpdaterTest::SetUp() {
get_interceptor_.reset(new GetInterceptor);
- interceptor_factory_.reset(new InterceptorFactory);
+ interceptor_factory_.reset(new InterceptorFactory(
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
post_interceptor_ = interceptor_factory_->CreateInterceptor();
EXPECT_TRUE(post_interceptor_);
}
« no previous file with comments | « no previous file | components/component_updater/test/component_patcher_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698