Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 514463002: app_shell: Allow getUserMedia to select a capture device by id (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

app_shell: Allow getUserMedia to select a capture device by id Return the device if it exists. Still return the first available device if getUserMedia() doesn't ask for one in particular. BUG=407236 TEST=manual Committed: https://crrev.com/df30065ad5553de910e9d955be5ecb9362f6245f Cr-Commit-Position: refs/heads/master@{#292061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -31 lines) Patch
M extensions/shell/browser/media_capture_util.h View 1 chunk +9 lines, -8 lines 0 comments Download
M extensions/shell/browser/media_capture_util.cc View 3 chunks +30 lines, -19 lines 0 comments Download
M extensions/shell/browser/shell_app_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_extension_host_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Cook
jamescook@chromium.org changed reviewers: + derat@chromium.org
6 years, 3 months ago (2014-08-26 23:48:58 UTC) #1
James Cook
Dan, PTAL. It turns out Hangouts requests the camera/mic by ID (even if there is ...
6 years, 3 months ago (2014-08-26 23:48:58 UTC) #2
Daniel Erat
lgtm
6 years, 3 months ago (2014-08-27 00:01:33 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 3 months ago (2014-08-27 00:02:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/514463002/1
6 years, 3 months ago (2014-08-27 00:03:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 9f58c64b00bfb41fec24ae193598df28cd106ff8
6 years, 3 months ago (2014-08-27 01:12:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df30065ad5553de910e9d955be5ecb9362f6245f
Cr-Commit-Position: refs/heads/master@{#292061}

Powered by Google App Engine
This is Rietveld 408576698