Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 514433002: Clear power consumption auditing when you clear history. (Closed)

Created:
6 years, 3 months ago by Daniel Nishi
Modified:
6 years, 3 months ago
CC:
chromium-reviews, markusheintz_, scheib
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clear power consumption auditing data when you clear history. This prevents the power consumption data from accidentally leaking visited websites after clearing browser history. Committed: https://crrev.com/e9c6f1e14435841021cce8f2aa3c201e64576fb6 Cr-Commit-Position: refs/heads/master@{#295558}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M components/power/origin_power_map.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/power/origin_power_map.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Daniel Nishi
bauerb: PTAL @ browsing_data_remover.cc derat: PTAL @ components/power/* Just got the go-ahead from markusheintz_ to ...
6 years, 3 months ago (2014-09-17 17:22:28 UTC) #2
Daniel Nishi
+scheib (CC): FYI
6 years, 3 months ago (2014-09-17 17:23:00 UTC) #3
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-17 17:27:15 UTC) #4
Daniel Erat
lgtm
6 years, 3 months ago (2014-09-18 15:48:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/514433002/1
6 years, 3 months ago (2014-09-18 19:47:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/68573) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57840) win_gpu ...
6 years, 3 months ago (2014-09-18 19:52:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/514433002/20001
6 years, 3 months ago (2014-09-18 20:12:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4363a9a508177e7e3706a5a8612558cbde035f7a
6 years, 3 months ago (2014-09-18 21:40:48 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:41:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9c6f1e14435841021cce8f2aa3c201e64576fb6
Cr-Commit-Position: refs/heads/master@{#295558}

Powered by Google App Engine
This is Rietveld 408576698