Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 514423002: Roll dom_distiller_js (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-intermediate-distilledpageinfo-structs
Project:
chromium
Visibility:
Public.

Description

Roll dom_distiller_js This also changes the way DomDistillerResult is read from base::Values by updating to the new version of DomDistillerResult::ReadFromValue which takes in a pointer to DomDistillerResult. This CL also makes it possible to continue using the update_domdistiller_js.sh script without modification by moving the BUILD.gn file for protos to outside of the generated package folder. Picked up changes: 432b2dc Added support for reading protos into a pointer. 32f096c don't prune a subtree when its only child is a text node. 90dc83c bump up nested-table heuristic 6f59530 Make comment filter a little more restrictive. BUG=368941, 408292, 409274 Committed: https://crrev.com/276e0ebd79574273c2e32651d70dfa19b9f3ba08 Cr-Commit-Position: refs/heads/master@{#293275}

Patch Set 1 #

Patch Set 2 : Merged with timing info upstream change #

Patch Set 3 : Added roll #

Patch Set 4 : Add back build.gn #

Patch Set 5 : Moved BUILD.gn file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -205 lines) Patch
M components/dom_distiller/core/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller_page.cc View 1 1 chunk +8 lines, -6 lines 0 comments Download
A + third_party/dom_distiller_js/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/package/js/domdistiller.js View 1 2 14 chunks +92 lines, -92 lines 0 comments Download
D third_party/dom_distiller_js/package/proto/BUILD.gn View 1 2 4 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h View 1 2 22 chunks +80 lines, -82 lines 0 comments Download

Messages

Total messages: 21 (5 generated)
nyquist
nyquist@chromium.org changed reviewers: + cjhopman@chromium.org
6 years, 3 months ago (2014-08-28 22:10:34 UTC) #1
nyquist
cjhopman: PTAL Still need to submit the CL in the other repository and roll to ...
6 years, 3 months ago (2014-08-28 22:10:34 UTC) #2
nyquist
6 years, 3 months ago (2014-08-29 23:48:13 UTC) #3
cjhopman
this looks fine, can you add the actual roll to it?
6 years, 3 months ago (2014-09-02 20:30:40 UTC) #4
nyquist
Will submit external repo CL and add the roll as soon as I have submitted ...
6 years, 3 months ago (2014-09-02 20:38:10 UTC) #5
nyquist
cjhopman: PTAL. Added the roll.
6 years, 3 months ago (2014-09-03 18:19:23 UTC) #6
nyquist
Also, why on earth did the update-script remove the BUILD.gn file? I am guessing that ...
6 years, 3 months ago (2014-09-03 18:27:39 UTC) #7
cjhopman
On 2014/09/03 18:27:39, nyquist wrote: > Also, why on earth did the update-script remove the ...
6 years, 3 months ago (2014-09-03 19:30:28 UTC) #8
nyquist
easy to repro. moved BUILD.gn out of generated package folder.
6 years, 3 months ago (2014-09-03 20:55:24 UTC) #9
nyquist
PTAL
6 years, 3 months ago (2014-09-03 20:55:47 UTC) #10
cjhopman
lgtm
6 years, 3 months ago (2014-09-03 21:05:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/514423002/60002
6 years, 3 months ago (2014-09-03 23:23:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1902) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/4996)
6 years, 3 months ago (2014-09-04 02:12:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/514423002/60002
6 years, 3 months ago (2014-09-04 06:49:23 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:60002) as e02e44e8d35654d43b198ff99859433da437ce93
6 years, 3 months ago (2014-09-04 06:51:05 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:30:28 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/276e0ebd79574273c2e32651d70dfa19b9f3ba08
Cr-Commit-Position: refs/heads/master@{#293275}

Powered by Google App Engine
This is Rietveld 408576698