Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 514383003: Second attempt to land the integral image scaling change. (Closed)

Created:
6 years, 3 months ago by humper
Modified:
6 years, 3 months ago
Reviewers:
reed, reed1
CC:
reviews_skia.org, mtklein, jbroman
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Second attempt to land the integral image scaling change. Scale all images to the nearest rounded integer, and if there's still any scaling factor left over, pass it on to the subsequent bilerp code. Should avoid artifacts when tiling scaled images. Original CL received an LGTM from reed; new version disabled tiling in the downsamplebitmap GM; I verified that this fixes the issue we were seeing there on non-neon androids. BUG=skia:2888 TBR=reed Committed: https://skia.googlesource.com/skia/+/d73c169637f1ab0b96bae43269da7216bb93a7e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -18 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M gm/downsamplebitmap.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 5 chunks +33 lines, -13 lines 0 comments Download
M tests/ScaledImageCache.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
humper
The CQ bit was checked by humper@google.com
6 years, 3 months ago (2014-08-28 21:08:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/514383003/1
6 years, 3 months ago (2014-08-28 21:10:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d73c169637f1ab0b96bae43269da7216bb93a7e1
6 years, 3 months ago (2014-08-28 21:27:45 UTC) #3
reed1
reed@google.com changed reviewers: + reed@google.com
6 years, 3 months ago (2014-08-28 21:36:09 UTC) #4
reed1
6 years, 3 months ago (2014-08-28 21:36:09 UTC) #5
Message was sent while issue was closed.
I presume this is a sort of diagnostic land, to validate that certain failures
will now be fixed, but do we understand the perf regression from the original
land?

Powered by Google App Engine
This is Rietveld 408576698