Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Side by Side Diff: components/precache/content/precache_manager.cc

Issue 514353002: Check if precaching is allowed before reporting related metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/precache/content/precache_manager.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/precache/content/precache_manager.h" 5 #include "components/precache/content/precache_manager.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/metrics/field_trial.h" 11 #include "base/metrics/field_trial.h"
12 #include "base/prefs/pref_service.h"
12 #include "base/time/time.h" 13 #include "base/time/time.h"
14 #include "components/data_reduction_proxy/common/data_reduction_proxy_pref_names .h"
13 #include "components/precache/core/precache_database.h" 15 #include "components/precache/core/precache_database.h"
14 #include "components/precache/core/precache_switches.h" 16 #include "components/precache/core/precache_switches.h"
15 #include "components/precache/core/url_list_provider.h" 17 #include "components/precache/core/url_list_provider.h"
18 #include "components/user_prefs/user_prefs.h"
16 #include "content/public/browser/browser_context.h" 19 #include "content/public/browser/browser_context.h"
17 #include "content/public/browser/browser_thread.h" 20 #include "content/public/browser/browser_thread.h"
18 #include "net/base/network_change_notifier.h" 21 #include "net/base/network_change_notifier.h"
19 22
20 using content::BrowserThread; 23 using content::BrowserThread;
21 24
22 namespace { 25 namespace {
23 26
24 const char kPrecacheFieldTrialName[] = "Precache"; 27 const char kPrecacheFieldTrialName[] = "Precache";
25 const char kPrecacheFieldTrialEnabledGroup[] = "Enabled"; 28 const char kPrecacheFieldTrialEnabledGroup[] = "Enabled";
(...skipping 17 matching lines...) Expand all
43 46
44 PrecacheManager::~PrecacheManager() {} 47 PrecacheManager::~PrecacheManager() {}
45 48
46 // static 49 // static
47 bool PrecacheManager::IsPrecachingEnabled() { 50 bool PrecacheManager::IsPrecachingEnabled() {
48 return base::FieldTrialList::FindFullName(kPrecacheFieldTrialName) == 51 return base::FieldTrialList::FindFullName(kPrecacheFieldTrialName) ==
49 kPrecacheFieldTrialEnabledGroup || 52 kPrecacheFieldTrialEnabledGroup ||
50 CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnablePrecache); 53 CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnablePrecache);
51 } 54 }
52 55
56 bool PrecacheManager::IsPrecachingAllowed() {
57 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
58 #if defined(SPDY_PROXY_AUTH_ORIGIN)
59 return user_prefs::UserPrefs::Get(browser_context_)->GetBoolean(
60 data_reduction_proxy::prefs::kDataReductionProxyEnabled);
61 #else
62 return false;
63 #endif
64 }
65
53 void PrecacheManager::StartPrecaching( 66 void PrecacheManager::StartPrecaching(
54 const PrecacheCompletionCallback& precache_completion_callback, 67 const PrecacheCompletionCallback& precache_completion_callback,
55 URLListProvider* url_list_provider) { 68 URLListProvider* url_list_provider) {
56 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 69 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
57 70
58 if (is_precaching_) { 71 if (is_precaching_) {
59 DLOG(WARNING) << "Cannot start precaching because precaching is already " 72 DLOG(WARNING) << "Cannot start precaching because precaching is already "
60 "in progress."; 73 "in progress.";
61 return; 74 return;
62 } 75 }
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 return; 167 return;
155 } 168 }
156 169
157 // Start precaching. 170 // Start precaching.
158 precache_fetcher_.reset( 171 precache_fetcher_.reset(
159 new PrecacheFetcher(urls, browser_context_->GetRequestContext(), this)); 172 new PrecacheFetcher(urls, browser_context_->GetRequestContext(), this));
160 precache_fetcher_->Start(); 173 precache_fetcher_->Start();
161 } 174 }
162 175
163 } // namespace precache 176 } // namespace precache
OLDNEW
« no previous file with comments | « components/precache/content/precache_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698