Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 514333002: [NaCl SDK] Add pepper_38 to naclsdk_manifest2.json (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/7eeeb113711aa2a073a75cc452cbaf7e8c089a15 Cr-Commit-Position: refs/heads/master@{#292478}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sam Clegg
sbc@chromium.org changed reviewers: + binji@chromium.org
6 years, 3 months ago (2014-08-28 19:19:33 UTC) #1
Sam Clegg
6 years, 3 months ago (2014-08-28 19:19:33 UTC) #2
binji
lgtm https://codereview.chromium.org/514333002/diff/1/native_client_sdk/src/build_tools/json/naclsdk_manifest2.json File native_client_sdk/src/build_tools/json/naclsdk_manifest2.json (right): https://codereview.chromium.org/514333002/diff/1/native_client_sdk/src/build_tools/json/naclsdk_manifest2.json#newcode213 native_client_sdk/src/build_tools/json/naclsdk_manifest2.json:213: "version": 37 38
6 years, 3 months ago (2014-08-28 22:07:42 UTC) #3
Sam Clegg
https://codereview.chromium.org/514333002/diff/1/native_client_sdk/src/build_tools/json/naclsdk_manifest2.json File native_client_sdk/src/build_tools/json/naclsdk_manifest2.json (right): https://codereview.chromium.org/514333002/diff/1/native_client_sdk/src/build_tools/json/naclsdk_manifest2.json#newcode213 native_client_sdk/src/build_tools/json/naclsdk_manifest2.json:213: "version": 37 On 2014/08/28 22:07:42, binji wrote: > 38 ...
6 years, 3 months ago (2014-08-28 22:14:21 UTC) #4
Sam Clegg
Committed patchset #2 (id:20001) to pending queue manually as 0408b859 (presubmit successful).
6 years, 3 months ago (2014-08-28 22:16:37 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:47 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7eeeb113711aa2a073a75cc452cbaf7e8c089a15
Cr-Commit-Position: refs/heads/master@{#292478}

Powered by Google App Engine
This is Rietveld 408576698