Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10134)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/permissions/permissions_data_unittest.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/api/sockets/sockets_handler.h ('K') | « chrome/common/extensions/permissions/permissions_data.cc ('k') | chrome/renderer/extensions/dispatcher.h » ('j') | extensions/common/permissions/manifest_permission_set_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/permissions_data_unittest.cc
diff --git a/chrome/common/extensions/permissions/permissions_data_unittest.cc b/chrome/common/extensions/permissions/permissions_data_unittest.cc
index c2bdb07620c68d3a381d7ade2be45137179b24e7..f4e0d3ef35b9314824dd9df174b7852e0dca68fa 100644
--- a/chrome/common/extensions/permissions/permissions_data_unittest.cc
+++ b/chrome/common/extensions/permissions/permissions_data_unittest.cc
@@ -548,7 +548,8 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
{
scoped_refptr<PermissionSet> permissions(
- new PermissionSet(APIPermissionSet(), allowed_hosts, URLPatternSet()));
+ new PermissionSet(APIPermissionSet(), ManifestPermissionSet(),
+ allowed_hosts, URLPatternSet()));
PermissionsData::UpdateTabSpecificPermissions(
extension.get(), 0, permissions);
EXPECT_EQ(permissions->explicit_hosts(),
@@ -576,7 +577,8 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
{
scoped_refptr<PermissionSet> permissions(
- new PermissionSet(APIPermissionSet(), allowed_hosts, URLPatternSet()));
+ new PermissionSet(APIPermissionSet(), ManifestPermissionSet(),
+ allowed_hosts, URLPatternSet()));
PermissionsData::UpdateTabSpecificPermissions(
extension.get(), 0, permissions);
EXPECT_EQ(permissions->explicit_hosts(),
@@ -584,6 +586,7 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
->explicit_hosts());
permissions = new PermissionSet(APIPermissionSet(),
+ ManifestPermissionSet(),
more_allowed_hosts,
URLPatternSet());
PermissionsData::UpdateTabSpecificPermissions(
« chrome/common/extensions/api/sockets/sockets_handler.h ('K') | « chrome/common/extensions/permissions/permissions_data.cc ('k') | chrome/renderer/extensions/dispatcher.h » ('j') | extensions/common/permissions/manifest_permission_set_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698