chrome/common/extensions/permissions/chrome_permission_message_provider.h - Issue 51433002: Enable permission warnings from ManifestHandlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider.h

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/sockets/sockets_handler.h ('K') | « chrome/common/extensions/extension_messages.cc ('k') | chrome/common/extensions/permissions/chrome_permission_message_provider.cc » ('j') | extensions/common/permissions/manifest_permission_set_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_provider.h

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider.h b/chrome/common/extensions/permissions/chrome_permission_message_provider.h

index 05125f43763d156431702e5370e712d84931bbf6..44b122c8c2465c8c47967443525c39e688634ab1 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_provider.h

+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider.h

@@ -39,6 +39,10 @@ class ChromePermissionMessageProvider : public PermissionMessageProvider {

std::set<PermissionMessage> GetAPIPermissionMessages(

const PermissionSet* permissions) const;

+ // Gets the permission messages for the Manifest permissions.

+ std::set<PermissionMessage> GetManifestPermissionMessages(

+ const PermissionSet* permissions) const;

// Gets the permission messages for the host permissions.

std::set<PermissionMessage> GetHostPermissionMessages(

const PermissionSet* permissions,