Chromium Code Reviews| Index: chrome/browser/extensions/api/permissions/permissions_api_helpers.cc |
| diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc |
| index 620c8c5f6b5f872dcd237592027cf6265e1051fd..05764127de7b22a0d1c13c64658640d24868dee5 100644 |
| --- a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc |
| +++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc |
| @@ -56,6 +56,9 @@ scoped_ptr<Permissions> PackPermissionSet(const PermissionSet* set) { |
| } |
| } |
| + // TODO(rpaquay): We currently don't expose manifest permissions |
| + // to apps/extensions. |
|
Yoyo Zhou
2013/11/09 01:15:30
via the permissions API?
rpaquay
2013/11/11 18:37:35
Correct. I think we'd need to revamp the permissio
|
| + |
| permissions->origins.reset(new std::vector<std::string>()); |
| URLPatternSet hosts = set->explicit_hosts(); |
| for (URLPatternSet::const_iterator i = hosts.begin(); i != hosts.end(); ++i) |
| @@ -121,6 +124,10 @@ scoped_refptr<PermissionSet> UnpackPermissionSet( |
| } |
| } |
| + // TODO(rpaquay): We currently don't expose manifest permissions |
| + // to apps/extensions. |
| + ManifestPermissionSet manifest_permissions; |
| + |
| URLPatternSet origins; |
| if (permissions.origins.get()) { |
| for (std::vector<std::string>::iterator it = permissions.origins->begin(); |
| @@ -142,7 +149,7 @@ scoped_refptr<PermissionSet> UnpackPermissionSet( |
| } |
| return scoped_refptr<PermissionSet>( |
| - new PermissionSet(apis, origins, URLPatternSet())); |
| + new PermissionSet(apis, manifest_permissions, origins, URLPatternSet())); |
| } |
| } // namespace permissions_api_helpers |