chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc - Issue 51433002: Enable permission warnings from ManifestHandlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test and clang presubmit errors. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc

diff --git a/chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc b/chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc

index 729587fd3bfe3012375a7c855073151b92e5ab05..fbf02dc0a1e0561a3a3e7ed3c3f0399a2e7e4974 100644

--- a/chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc

+++ b/chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc

@@ -6,7 +6,7 @@

#include "chrome/browser/extensions/api/socket/tcp_socket.h"

#include "chrome/browser/extensions/api/sockets_tcp/tcp_socket_event_dispatcher.h"

-#include "chrome/common/extensions/api/sockets/sockets_handler.h"

+#include "chrome/common/extensions/api/sockets/sockets_manifest_data.h"

#include "content/public/common/socket_permission_request.h"

#include "net/base/net_errors.h"