Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: chrome/common/extensions/manifest_handler.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Working on adding ManifestPermissionSet to PermissionSet. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handler.cc
diff --git a/chrome/common/extensions/manifest_handler.cc b/chrome/common/extensions/manifest_handler.cc
index fbd2201b01e33ea9be8ff1527dda66c05a7c6e18..81150193f183d1d22f0d8b0005224b3b6e01c93c 100644
--- a/chrome/common/extensions/manifest_handler.cc
+++ b/chrome/common/extensions/manifest_handler.cc
@@ -57,6 +57,18 @@ void ManifestHandler::Register() {
GetRegistry()->RegisterManifestHandler(keys[i], this_linked);
}
+void ManifestHandler::AddPermissionWarningMessages(
+ const Extension* extension,
+ std::vector<string16>& messages) const {
+ // Nothing by default
+}
+
+void ManifestHandler::AddPermissionWarningMessagesDetails(
+ const Extension* extension,
+ std::vector<string16>& messages) const {
+ // Nothing by default
+}
+
// static
void ManifestHandler::FinalizeRegistration() {
GetRegistry()->Finalize();
@@ -80,6 +92,18 @@ bool ManifestHandler::ValidateExtension(const Extension* extension,
}
// static
+std::vector<string16> ManifestHandler::
+ GetExtensionPermissionWarningMessages(const Extension* extension) {
+ return GetRegistry()->GetExtensionPermissionWarningMessages(extension);
+}
+
+// static
+std::vector<string16> ManifestHandler::
+ GetExtensionPermissionWarningMessagesDetails(const Extension* extension) {
+ return GetRegistry()->GetExtensionPermissionWarningMessagesDetails(extension);
+}
+
+// static
const std::vector<std::string> ManifestHandler::SingleKey(
const std::string& key) {
return std::vector<std::string>(1, key);
@@ -144,6 +168,28 @@ bool ManifestHandlerRegistry::ValidateExtension(
return true;
}
+std::vector<string16> ManifestHandlerRegistry::
+ GetExtensionPermissionWarningMessages(const Extension* extension) {
+ std::vector<string16> result;
+ for (ManifestHandlerMap::iterator iter = handlers_.begin();
+ iter != handlers_.end(); ++iter) {
+ ManifestHandler* handler = iter->second.get();
+ handler->AddPermissionWarningMessages(extension, result);
+ }
+ return result;
+}
+
+std::vector<string16> ManifestHandlerRegistry::
+ GetExtensionPermissionWarningMessagesDetails(const Extension* extension) {
+ std::vector<string16> result;
+ for (ManifestHandlerMap::iterator iter = handlers_.begin();
+ iter != handlers_.end(); ++iter) {
+ ManifestHandler* handler = iter->second.get();
+ handler->AddPermissionWarningMessagesDetails(extension, result);
+ }
+ return result;
+}
+
// static
ManifestHandlerRegistry* ManifestHandlerRegistry::SetForTesting(
ManifestHandlerRegistry* new_registry) {

Powered by Google App Engine
This is Rietveld 408576698