Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/common/extensions/api/sockets/sockets_handler.h

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Working on adding ManifestPermissionSet to PermissionSet. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/sockets/sockets_handler.h
diff --git a/chrome/common/extensions/api/sockets/sockets_handler.h b/chrome/common/extensions/api/sockets/sockets_handler.h
index ff280d1231a5e46f29ff1fed4ad1bc38976e3ae1..46157e54e028228246d7ee9f08b68a3f6b1882a7 100644
--- a/chrome/common/extensions/api/sockets/sockets_handler.h
+++ b/chrome/common/extensions/api/sockets/sockets_handler.h
@@ -19,6 +19,12 @@ class SocketsHandler : public ManifestHandler {
virtual ~SocketsHandler();
virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
+ virtual void AddPermissionWarningMessages(
+ const Extension* extension,
+ std::vector<string16>& messages) const OVERRIDE;
+ virtual void AddPermissionWarningMessagesDetails(
+ const Extension* extension,
+ std::vector<string16>& messages) const OVERRIDE;
private:
virtual const std::vector<std::string> Keys() const OVERRIDE;
@@ -32,7 +38,7 @@ class SocketsManifestData : public Extension::ManifestData {
SocketsManifestData();
virtual ~SocketsManifestData();
- // Gets the ExternallyConnectableInfo for |extension|, or NULL if none was
+ // Gets the SocketsManifestData for |extension|, or NULL if none was
// specified.
static SocketsManifestData* Get(const Extension* extension);
@@ -46,6 +52,8 @@ class SocketsManifestData : public Extension::ManifestData {
std::vector<InstallWarning>* install_warnings,
string16* error);
+ PermissionMessages GetPermissionMessages() const;
+
private:
typedef std::set<SocketPermissionEntry> PermissionSet;
@@ -60,6 +68,11 @@ class SocketsManifestData : public Extension::ManifestData {
bool CheckRequestImpl(const Extension* extension,
const content::SocketPermissionRequest& request);
+ bool AddAnyHostMessage(PermissionMessages& messages) const;
+ void AddSubdomainHostMessage(PermissionMessages& messages) const;
+ void AddSpecificHostMessage(PermissionMessages& messages) const;
+ void AddNetworkListMessage(PermissionMessages& messages) const;
+
PermissionSet permissions_;
};

Powered by Google App Engine
This is Rietveld 408576698