chrome/browser/extensions/active_tab_permission_granter.cc - Issue 51433002: Enable permission warnings from ManifestHandlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_permission_granter.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Working on adding ManifestPermissionSet to PermissionSet. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/active_tab_permission_granter.cc

diff --git a/chrome/browser/extensions/active_tab_permission_granter.cc b/chrome/browser/extensions/active_tab_permission_granter.cc

index d8c0ce6e64330acaed70dd3bcda2326e00f6e8fe..aebeb39cc8eb208c76eb332d594b4f06b5b9e50b 100644

--- a/chrome/browser/extensions/active_tab_permission_granter.cc

+++ b/chrome/browser/extensions/active_tab_permission_granter.cc

@@ -59,7 +59,8 @@ void ActiveTabPermissionGranter::GrantIfRequested(const Extension* extension) {

if (!new_apis.empty() || !new_hosts.is_empty()) {

granted_extensions_.Insert(extension);

scoped_refptr<const PermissionSet> new_permissions =

- new PermissionSet(new_apis, new_hosts, URLPatternSet());

+ new PermissionSet(new_apis, ManifestPermissionSet(),

+ new_hosts, URLPatternSet());

PermissionsData::UpdateTabSpecificPermissions(extension,

tab_id_,

new_permissions);