Enable permission warnings from ManifestHandlers.

extensions/common/manifest_handler.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_H_
 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/memory/linked_ptr.h"
 #include "base/strings/string16.h"
 #include "extensions/common/manifest.h"
 
 namespace extensions {
 class Extension;
+class ManifestPermission;
+class ManifestPermissionSet;
 
 // An interface for clients that recognize and parse keys in extension
 // manifests.
 class ManifestHandler {
  public:
   ManifestHandler();
   virtual ~ManifestHandler();
 
   // Attempts to parse the extension's manifest.
   // Returns true on success or false on failure; if false, |error| will
@@ skipping 28 matching lines @@
   virtual const std::vector<std::string> PrerequisiteKeys() const;
 
   // Associate us with our keys() in the manifest. A handler can register
   // for multiple keys. The global registry takes ownership of this;
   // if it has an existing handler for |key|, it replaces it with this.
   // Manifest handlers must be registered at process startup in
   // chrome_manifest_handlers.cc:
   // (new MyManifestHandler)->Register();
   void Register();
 
+  virtual ManifestPermission* CreatePermission();

[Yoyo Zhou, 2013/11/12 02:39:29]

These new functions need documentation.

[rpaquay, 2013/11/12 21:40:31]

Done.

+  virtual ManifestPermission* CreateInitialRequiredPermission(
+      const Extension* extension);
+
   // Calling FinalizeRegistration indicates that there are no more
   // manifest handlers to be registered.
   static void FinalizeRegistration();
 
   static bool IsRegistrationFinalized();
 
   // Call Parse on all registered manifest handlers that should parse
   // this extension.
   static bool ParseExtension(Extension* extension, string16* error);
 
   // Call Validate on all registered manifest handlers for this extension.
   static bool ValidateExtension(const Extension* extension,
                                 std::string* error,
                                 std::vector<InstallWarning>* warnings);
 
+  static ManifestPermission* CreatePermission(const std::string& name);
+
+  static void AddExtensionRequiredPermissions(
+      const Extension* extension, ManifestPermissionSet* permission_set);
+
  protected:
   // A convenience method for handlers that only register for 1 key,
   // so that they can define keys() { return SingleKey(kKey); }
   static const std::vector<std::string> SingleKey(const std::string& key);
 
  private:
   // The keys to register us for (in Register).
   virtual const std::vector<std::string> Keys() const = 0;
 };
 
 // The global registry for manifest handlers.
 class ManifestHandlerRegistry {
  private:
   friend class ManifestHandler;
   friend class ScopedTestingManifestHandlerRegistry;
   friend struct base::DefaultLazyInstanceTraits<ManifestHandlerRegistry>;
 
   ManifestHandlerRegistry();
   ~ManifestHandlerRegistry();
 
   void Finalize();
 
   void RegisterManifestHandler(const std::string& key,
                                linked_ptr<ManifestHandler> handler);
   bool ParseExtension(Extension* extension, string16* error);
   bool ValidateExtension(const Extension* extension,
                          std::string* error,
                          std::vector<InstallWarning>* warnings);
 
+  ManifestPermission* CreatePermission(const std::string& name);
+
+  void AddExtensionRequiredPermissions(const Extension* extension,
+                                       ManifestPermissionSet* permission_set);
+
   // Overrides the current global ManifestHandlerRegistry with
   // |registry|, returning the current one.
   static ManifestHandlerRegistry* SetForTesting(
       ManifestHandlerRegistry* new_registry);
 
   typedef std::map<std::string, linked_ptr<ManifestHandler> >
       ManifestHandlerMap;
   typedef std::map<ManifestHandler*, int> ManifestHandlerPriorityMap;
 
   // Puts the manifest handlers in order such that each handler comes after
   // any handlers for their PrerequisiteKeys. If there is no handler for
   // a prerequisite key, that dependency is simply ignored.
   // CHECKs that there are no manifest handlers with circular dependencies.
   void SortManifestHandlers();
 
   // All registered manifest handlers.
   ManifestHandlerMap handlers_;
 
   // The priority for each manifest handler. Handlers with lower priority
   // values are evaluated first.
   ManifestHandlerPriorityMap priority_map_;
 
   bool is_finalized_;
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_MANIFEST_HANDLER_H_