Enable permission warnings from ManifestHandlers.

extensions/common/manifest_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest_handler.h"
 
 #include <map>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "chrome/common/extensions/extension.h"
+#include "extensions/common/permissions/api_permission_set.h"
 
 namespace extensions {
 
 namespace {
 
 static base::LazyInstance<ManifestHandlerRegistry> g_registry =
     LAZY_INSTANCE_INITIALIZER;
 static ManifestHandlerRegistry* g_registry_override = NULL;
 
 ManifestHandlerRegistry* GetRegistry() {
@@ skipping 28 matching lines @@
   return std::vector<std::string>();
 }
 
 void ManifestHandler::Register() {
   linked_ptr<ManifestHandler> this_linked(this);
   const std::vector<std::string> keys = Keys();
   for (size_t i = 0; i < keys.size(); ++i)
     GetRegistry()->RegisterManifestHandler(keys[i], this_linked);
 }
 
+ManifestPermission* ManifestHandler::CreatePermission() {
+  return NULL;
+}
+
+ManifestPermission* ManifestHandler::CreateInitialRequiredPermission(
+    const Extension* extension) {
+  return NULL;
+}
+
 // static
 void ManifestHandler::FinalizeRegistration() {
   GetRegistry()->Finalize();
 }
 
 // static
 bool ManifestHandler::IsRegistrationFinalized() {
   return GetRegistry()->is_finalized_;
 }
 
 // static
 bool ManifestHandler::ParseExtension(Extension* extension, string16* error) {
   return GetRegistry()->ParseExtension(extension, error);
 }
 
 // static
 bool ManifestHandler::ValidateExtension(const Extension* extension,
                                         std::string* error,
                                         std::vector<InstallWarning>* warnings) {
   return GetRegistry()->ValidateExtension(extension, error, warnings);
 }
 
 // static
+ManifestPermission* ManifestHandler::CreatePermission(const std::string& name) {
+  return GetRegistry()->CreatePermission(name);
+}
+
+// static
+void ManifestHandler::AddExtensionRequiredPermissions(
+    const Extension* extension, ManifestPermissionSet* permission_set) {
+  return GetRegistry()->AddExtensionRequiredPermissions(extension,
+                                                        permission_set);
+}
+
+// static
 const std::vector<std::string> ManifestHandler::SingleKey(
     const std::string& key) {
   return std::vector<std::string>(1, key);
 }
 
 ManifestHandlerRegistry::ManifestHandlerRegistry() : is_finalized_(false) {
 }
 
 ManifestHandlerRegistry::~ManifestHandlerRegistry() {
 }
@@ skipping 44 matching lines @@
     }
   }
   for (std::set<ManifestHandler*>::iterator iter = handlers.begin();
        iter != handlers.end(); ++iter) {
     if (!(*iter)->Validate(extension, error, warnings))
       return false;
   }
   return true;
 }
 
+ManifestPermission* ManifestHandlerRegistry::CreatePermission(
+    const std::string& name) {
+  ManifestHandlerMap::const_iterator it = handlers_.find(name);
+  if (it == handlers_.end())
+    return NULL;
+
+  return it->second->CreatePermission();
+}
+
+void ManifestHandlerRegistry::AddExtensionRequiredPermissions(
+    const Extension* extension, ManifestPermissionSet* permission_set) {
+  for (ManifestHandlerMap::const_iterator it = handlers_.begin();
+      it != handlers_.end(); ++it) {
+    ManifestPermission* permission =
+        it->second->CreateInitialRequiredPermission(extension);
+    if (permission) {
+      permission_set->insert(permission);
+    }
+  }
+}
+
 // static
 ManifestHandlerRegistry* ManifestHandlerRegistry::SetForTesting(
     ManifestHandlerRegistry* new_registry) {
   ManifestHandlerRegistry* old_registry = GetRegistry();
   if (new_registry != g_registry.Pointer())
     g_registry_override = new_registry;
   else
     g_registry_override = NULL;
   return old_registry;
 }
@@ skipping 39 matching lines @@
     unsorted_handlers.swap(next_unsorted_handlers);
   }
 
   // If there are any leftover unsorted handlers, they must have had
   // circular dependencies.
   CHECK(unsorted_handlers.size() == 0) << "Extension manifest handlers have "
                                        << "circular dependencies!";
 }
 
 }  // namespace extensions