Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: chrome/browser/extensions/api/sockets_udp/sockets_udp_api.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test and clang presubmit errors. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/sockets_udp/sockets_udp_api.h" 5 #include "chrome/browser/extensions/api/sockets_udp/sockets_udp_api.h"
6 6
7 #include "chrome/browser/extensions/api/socket/udp_socket.h" 7 #include "chrome/browser/extensions/api/socket/udp_socket.h"
8 #include "chrome/browser/extensions/api/sockets_udp/udp_socket_event_dispatcher. h" 8 #include "chrome/browser/extensions/api/sockets_udp/udp_socket_event_dispatcher. h"
9 #include "chrome/common/extensions/api/sockets/sockets_handler.h" 9 #include "chrome/common/extensions/api/sockets/sockets_manifest_data.h"
10 #include "content/public/common/socket_permission_request.h" 10 #include "content/public/common/socket_permission_request.h"
11 #include "net/base/net_errors.h" 11 #include "net/base/net_errors.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 namespace api { 14 namespace api {
15 15
16 using content::SocketPermissionRequest; 16 using content::SocketPermissionRequest;
17 17
18 const char kSocketNotFoundError[] = "Socket not found"; 18 const char kSocketNotFoundError[] = "Socket not found";
19 const char kPermissionError[] = "App does not have permission"; 19 const char kPermissionError[] = "App does not have permission";
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 error_ = kPermissionError; 458 error_ = kPermissionError;
459 return; 459 return;
460 } 460 }
461 461
462 const std::vector<std::string>& groups = socket->GetJoinedGroups(); 462 const std::vector<std::string>& groups = socket->GetJoinedGroups();
463 results_ = sockets_udp::GetJoinedGroups::Results::Create(groups); 463 results_ = sockets_udp::GetJoinedGroups::Results::Create(groups);
464 } 464 }
465 465
466 } // namespace api 466 } // namespace api
467 } // namespace extensions 467 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698