Issue 514313003: Fix memory leak in SkPDFType1Font

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 514313003: Fix memory leak in SkPDFType1Font (Closed)

Created:
6 years, 3 months ago by djsollen

Modified:
6 years, 3 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org, hal.canary

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pdf/SkPDFFont.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

djsollen

djsollen@google.com changed reviewers: + bungeman@google.com

6 years, 3 months ago (2014-08-28 19:10:48 UTC) #1

bungeman-skia

Looking at how the ref counting works here and how the CID font stuff below ...

6 years, 3 months ago (2014-08-28 19:18:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/514313003/1

6 years, 3 months ago (2014-08-28 19:21:39 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-08-28 19:34:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 7ba2828aa6687f9d12f4fa0b0a2ef9a9dc2efa68