Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 514293003: Run athena on chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index b9250c6500f61d8419585e42c90b4971769113a6..c578a0aac32972c8a6f2e34ed9305238750c2abc 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -388,11 +388,16 @@ void ChromeBrowserMainPartsChromeos::PreProfileInit() {
// Initialize magnification manager before ash tray is created. And this must
// be placed after UserManager::SessionStarted();
AccessibilityManager::Initialize();
+#if !defined(USE_ATHENA)
+ // TODO(oshima): MagnificationManager/WallpaperManager depends on ash.
+ // crbug.com/408733, crbug.com/408734.
+
Mr4D (OOO till 08-26) 2014/08/29 00:09:59 Sorry for this stupid nit but this empty line can
oshima 2014/08/29 00:44:43 Done.
MagnificationManager::Initialize();
// Add observers for WallpaperManager. This depends on PowerManagerClient,
// TimezoneSettings and CrosSettings.
WallpaperManager::Get()->AddObservers();
+#endif
cros_version_loader_.GetVersion(VersionLoader::VERSION_FULL,
base::Bind(&ChromeOSVersionCallback),
@@ -615,15 +620,19 @@ void ChromeBrowserMainPartsChromeos::PreBrowserStart() {
void ChromeBrowserMainPartsChromeos::PostBrowserStart() {
// These are dependent on the ash::Shell singleton already having been
// initialized.
+#if !defined(USE_ATHENA)
Jun Mukai 2014/08/28 22:50:45 It's better to mark the crbug URL so that we can d
oshima 2014/08/28 23:59:04 Done.
power_button_observer_.reset(new PowerButtonObserver);
+#endif
data_promo_notification_.reset(new DataPromoNotification());
keyboard_event_rewriters_.reset(new EventRewriterController());
keyboard_event_rewriters_->AddEventRewriter(
scoped_ptr<ui::EventRewriter>(new KeyboardDrivenEventRewriter()));
+#if !defined(USE_ATHENA)
Jun Mukai 2014/08/28 22:50:45 ditto
oshima 2014/08/28 23:59:04 Done.
keyboard_event_rewriters_->AddEventRewriter(scoped_ptr<ui::EventRewriter>(
new EventRewriter(ash::Shell::GetInstance()->sticky_keys_controller())));
keyboard_event_rewriters_->Init();
+#endif
ChromeBrowserMainPartsLinux::PostBrowserStart();
}

Powered by Google App Engine
This is Rietveld 408576698