chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.h - Issue 514293003: Run athena on chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.h

Issue 514293003: Run athena on chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_VIEWS_ATHENA_CHROME_BROWSER_MAIN_EXTRA_PARTS_ATHENA_H_

	6 #define CHROME_BROWSER_UI_VIEWS_ATHENA_CHROME_BROWSER_MAIN_EXTRA_PARTS_ATHENA_H_

	7

	8 class ChromeBrowserMainExtraParts;

	9

	10 // Creates the BrowserMainExtraParts for athena environment. Note that athena

	11 // and ash cannot coexist, and has to be exclusive.
	Yoyo Zhou 2014/08/29 22:23:30 nit: s/has to/must/ nit: s/has to/must/ oshima 2014/08/29 23:25:26 Done. Show quoted text On 2014/08/29 22:23:30, Yoyo Zhou wrote: > nit: s/has to/must/ Done.
	12 ChromeBrowserMainExtraParts* CreateChromeBrowserMainExtraPartsAthena();
	oshima 2014/08/29 22:11:19 sky@, let me know if 1) you want to have class def sky@, let me know if 1) you want to have class definition in this header, rather than in .cc 2) this should be c/b/ui/athena instead. I looked at several files, and decision seems to be rather random. (there are files in c/b/ui/ash that depend on views, w Looks like many files in c/b/ui/ash depend on (either directly or indirectly) views, and there are very few files in c/b/ui/views/ash. I can consolidate them if you agree. Please let me know.
	13

	14 #endif // CHROME_BROWSER_UI_VIEWS_ATHENA_CHROME_BROWSER_MAIN_EXTRA_PARTS_ATHENA _H_

OLD	NEW