mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl - Issue 514293002: Mojo: validate nullability in Java bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

Issue 514293002: Mojo: validate nullability in Java bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix line length in mojom_java_generator in a way that works. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java ('k') | mojo/public/tools/bindings/generators/mojom_java_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

index c878e026644537dcabae9854db51fddd732812ed..5903e4458bd41a795f4249989806a7216ed94115 100644

--- a/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

@@ -19,7 +19,7 @@ encoder{{level}}.{{kind|encode_method(variable, offset, bit)}};

{% macro decode(variable, kind, offset, bit, level=0) %}

{% if kind|is_struct_kind or kind|is_pointer_array_kind %}

-org.chromium.mojo.bindings.Decoder decoder{{level+1}} = decoder{{level}}.readPointer({{offset}});

+org.chromium.mojo.bindings.Decoder decoder{{level+1}} = decoder{{level}}.readPointer({{offset}}, {{kind|is_nullable_kind|java_true_false}});

{% if kind|is_struct_kind %}

{{variable}} = {{kind|java_type}}.decode(decoder{{level+1}});

{% else %}{# kind|is_pointer_array_kind #}