Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 514263002: Move common code and variables from audio/video sender to frame sender. (Closed)

Created:
6 years, 3 months ago by hubbe
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move common code and variables from audio/video sender to frame sender. More cleanup to come. BUG=406622 Committed: https://crrev.com/af6f467869648ac5e54a738bbaf43f4f1cf22842 Cr-Commit-Position: refs/heads/master@{#292496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -179 lines) Patch
M media/cast/sender/audio_sender.h View 2 chunks +0 lines, -42 lines 0 comments Download
M media/cast/sender/audio_sender.cc View 5 chunks +1 line, -47 lines 0 comments Download
M media/cast/sender/frame_sender.h View 2 chunks +43 lines, -0 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 2 chunks +45 lines, -0 lines 0 comments Download
M media/cast/sender/video_sender.h View 2 chunks +0 lines, -42 lines 0 comments Download
M media/cast/sender/video_sender.cc View 5 chunks +1 line, -48 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hubbe
hubbe@chromium.org changed reviewers: + hclam@chromium.org
6 years, 3 months ago (2014-08-28 18:19:24 UTC) #1
hubbe
6 years, 3 months ago (2014-08-28 18:19:24 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 3 months ago (2014-08-28 21:43:00 UTC) #3
Alpha Left Google
lgtm
6 years, 3 months ago (2014-08-28 21:43:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/514263002/1
6 years, 3 months ago (2014-08-28 21:43:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ca47e8e834990017ff30fbf777ea8712642ffd03
6 years, 3 months ago (2014-08-28 23:34:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af6f467869648ac5e54a738bbaf43f4f1cf22842
Cr-Commit-Position: refs/heads/master@{#292496}

Powered by Google App Engine
This is Rietveld 408576698