Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 514253002: Add strnlen() wrapper and its test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add strnlen() wrapper and its test. TEST=util_test strnlen.strnlen R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/af0cfd5a57cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -0 lines) Patch
A util/stdlib/strnlen.h View 1 chunk +49 lines, -0 lines 0 comments Download
A util/stdlib/strnlen.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A util/stdlib/strnlen_test.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M util/util.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
mark@chromium.org changed reviewers: + rsesek@chromium.org
6 years, 3 months ago (2014-08-28 18:13:15 UTC) #1
Mark Mentovai
6 years, 3 months ago (2014-08-28 18:13:15 UTC) #2
Robert Sesek
I'm surprised you didn't just conditionally declare this in the global namespace for SDKs < ...
6 years, 3 months ago (2014-08-28 18:33:01 UTC) #3
Mark Mentovai
Yes, that’s an alternative. strnlen() is new and support is spotty across a variety of ...
6 years, 3 months ago (2014-08-28 18:37:45 UTC) #4
Mark Mentovai
6 years, 3 months ago (2014-08-28 18:38:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as af0cfd5a57cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698