Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 514233002: HistoryService fixups for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

HistoryService fixups for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/56a2306889606b08d2adce13b466dffa541175db Cr-Commit-Position: refs/heads/master@{#292452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/history/history_service.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-28 17:43:37 UTC) #1
dcheng
Simple fixups. The automated tool skipped instances of converting temporary scoped_refptr's to T*s that it ...
6 years, 3 months ago (2014-08-28 17:43:37 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-08-28 18:27:24 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 18:28:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/514233002/1
6 years, 3 months ago (2014-08-28 18:30:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 19:23:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:12:06 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:12:07 UTC) #8
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 20:16:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/514233002/1
6 years, 3 months ago (2014-08-28 20:17:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:18:42 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:18:42 UTC) #12
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-28 20:34:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/514233002/1
6 years, 3 months ago (2014-08-28 20:34:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5310cc4d60fc99aafc87420bf7959b61f71fd482
6 years, 3 months ago (2014-08-28 20:35:55 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:53 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/56a2306889606b08d2adce13b466dffa541175db
Cr-Commit-Position: refs/heads/master@{#292452}

Powered by Google App Engine
This is Rietveld 408576698