Issue 51423002: Add a target_frame_id to the history serialization format.

Issue 51423002: Add a target_frame_id to the history serialization format. (Closed)

Created:
7 years, 1 month ago by Nate Chapin

Modified:
7 years, 1 month ago

Reviewers:
Charlie Reis, darin (slow to review), abarth-chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a target_frame_id to the history serialization format. BUG=312929 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232864

Patch Set 2 : Unconditionlly setTargetFrameID() #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
M	content/common/page_state_serialization.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/page_state_serialization.cc	View		4 chunks	+6 lines, -1 line	0 comments	Download
M	content/common/page_state_serialization_unittest.cc	View		4 chunks	+7 lines, -0 lines	0 comments	Download
M	content/public/renderer/history_item_serialization.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
A	content/test/data/page_state/serialized_v16.dat	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

This depends on https://codereview.chromium.org/46783003/ and will enable https://codereview.chromium.org/28983004/

7 years, 1 month ago (2013-10-29 20:57:45 UTC) #1

darin (slow to review)

https://codereview.chromium.org/51423002/diff/1/content/public/renderer/history_item_serialization.cc File content/public/renderer/history_item_serialization.cc (right): https://codereview.chromium.org/51423002/diff/1/content/public/renderer/history_item_serialization.cc#newcode142 content/public/renderer/history_item_serialization.cc:142: if (state.target_frame_id) The above comment does not apply to ...

7 years, 1 month ago (2013-10-29 23:05:50 UTC) #2

Nate Chapin

7 years, 1 month ago (2013-10-29 23:16:26 UTC) #3

Nate Chapin

On 2013/10/29 23:16:26, Nate Chapin wrote: > https://codereview.chromium.org/51423002/diff/1/content/public/renderer/history_item_serialization.cc > File content/public/renderer/history_item_serialization.cc (right): > > https://codereview.chromium.org/51423002/diff/1/content/public/renderer/history_item_serialization.cc#newcode142 ...

7 years, 1 month ago (2013-10-29 23:25:38 UTC) #4

Charlie Reis

LGTM, once we decide on which frame ID to use in https://codereview.chromium.org/46783003/.

7 years, 1 month ago (2013-10-30 16:27:44 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/51423002/30002

7 years, 1 month ago (2013-11-04 17:43:02 UTC) #7

Message was sent while issue was closed.

Change committed as 232864

Expand Messages | Collapse Messages