Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 514223002: Force-enable the software keyboard when running tests in iOS simulator. (Closed)

Created:
6 years, 3 months ago by lliabraa
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, stuartmorgan, rohitrao (ping after 24h)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Force-enable the software keyboard when running tests in iOS simulator. Xcode 6 introduced behavior in the iOS Simulator where the software keyboard does not appear if a hardware keyboard is connected. This CL enables the software keyboard when a gtest app starts up. BUG=392433 Committed: https://crrev.com/8537d1c315ae011220153e68a9017fedabb9bdea Cr-Commit-Position: refs/heads/master@{#292916}

Patch Set 1 #

Total comments: 4

Patch Set 2 : added comments for #endifs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M base/test/test_support_ios.mm View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
lliabraa
lliabraa@chromium.org changed reviewers: + phajdan.jr@chromium.org
6 years, 3 months ago (2014-08-28 17:13:47 UTC) #1
lliabraa
6 years, 3 months ago (2014-08-28 17:13:47 UTC) #2
lliabraa
6 years, 3 months ago (2014-08-28 17:41:04 UTC) #3
Paweł Hajdan Jr.
LGTM w/nits The comments don't need to literally match what I wrote if the style ...
6 years, 3 months ago (2014-08-29 09:48:29 UTC) #4
stuartmorgan
LGTM
6 years, 3 months ago (2014-08-29 18:36:38 UTC) #6
lliabraa
Thanks for the reviews. https://codereview.chromium.org/514223002/diff/1/base/test/test_support_ios.mm File base/test/test_support_ios.mm (right): https://codereview.chromium.org/514223002/diff/1/base/test/test_support_ios.mm#newcode46 base/test/test_support_ios.mm:46: #endif On 2014/08/29 09:48:29, Paweł ...
6 years, 3 months ago (2014-09-02 12:46:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/514223002/20001
6 years, 3 months ago (2014-09-02 12:47:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as aa8e29b122b8f69d8158c043c68498fbe229b21e
6 years, 3 months ago (2014-09-02 13:42:07 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8537d1c315ae011220153e68a9017fedabb9bdea
Cr-Commit-Position: refs/heads/master@{#292916}

Powered by Google App Engine
This is Rietveld 408576698