Expose platform thread id on WebThread

Expose platform thread id on WebThread

DevTools code needs access to platform thread id in order to collect Worker thread ids and based on them differentiate worker threads in recorded trace events.

BUG=401895
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181562

[yurys, 2014-08-28 15:17:19]

yurys@chromium.org changed reviewers:
+ alph@chromium.org, caseq@chromium.org, loislo@chromium.org,
pfeldman@chromium.org

[yurys, 2014-08-28 15:24:21]

https://codereview.chromium.org/514193002/diff/20001/public/platform/WebThread.h
File public/platform/WebThread.h (right):

https://codereview.chromium.org/514193002/diff/20001/public/platform/WebThrea...
public/platform/WebThread.h:34: typedef uint32_t PlatformThreadId;
I would define this as
#if OS(WIN)
typedef DWORD PlatformThreadId;
#elif OS(POSIX)
typedef pid_t PlatformThreadId;
#endif
here but I cannot use OS(WIN) macro without including config.h which is not
allowed in headers. So I just declared it as minimal type that would fit tid on
both Win and Posix systems. Alternatively I can add PlathformThreadIdWin.h and
PlathformThreadIdPosix.h and make blink_platform.gyp pick one of them based on
the current platform.

[alph, 2014-08-28 15:28:44]

lgtm

https://codereview.chromium.org/514193002/diff/40001/public/platform/WebThread.h
File public/platform/WebThread.h (right):

https://codereview.chromium.org/514193002/diff/40001/public/platform/WebThrea...
public/platform/WebThread.h:34: typedef uintptr_t PlatformThreadId;
nit: You can add a STATIC_ASSERT in a .cpp to make sure the real handle fits
into PlatformThreadId.

[yurys, 2014-08-28 16:08:55]

https://codereview.chromium.org/514193002/diff/40001/public/platform/WebThread.h
File public/platform/WebThread.h (right):

https://codereview.chromium.org/514193002/diff/40001/public/platform/WebThrea...
public/platform/WebThread.h:34: typedef uintptr_t PlatformThreadId;
On 2014/08/28 15:28:43, alph wrote:
> nit: You can add a STATIC_ASSERT in a .cpp to make sure the real handle fits
> into PlatformThreadId.

Done.

[yurys, 2014-09-08 08:01:49]

yurys@chromium.org changed reviewers:
+ jochen@chromium.org

[yurys, 2014-09-08 08:01:50]

@jochen: can you take a look please?

[jochen (gone - plz use gerrit), 2014-09-08 12:09:15]

lgtm

[yurys, 2014-09-08 12:36:41]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-09-08 12:37:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yurys@chromium.org/514193002/80001

[commit-bot: I haz the power, 2014-09-08 14:31:47]

Committed patchset #5 (id:80001) as 181562

[darin (slow to review), 2014-09-09 18:35:08]

darin@chromium.org changed reviewers:
+ darin@chromium.org

[darin (slow to review), 2014-09-09 18:35:08]

LGTM2