Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 514143003: Add IE PirateMark to tough_filters_cases page set. (Closed)

Created:
6 years, 3 months ago by Stephen White
Modified:
6 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/2b2408bc126ca89aac7050c68d1f03259efd7750 Cr-Commit-Position: refs/heads/master@{#292450}

Patch Set 1 #

Patch Set 2 : Add SHA1 of new .wpr file #

Patch Set 3 : Add JS click interaction to start benchmark #

Total comments: 1

Patch Set 4 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M tools/perf/page_sets/data/tough_filters_cases.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A tools/perf/page_sets/data/tough_filters_cases_001.wpr.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_filters_cases.py View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Stephen White
senorblanco@chromium.org changed reviewers: + dtu@chromium.org
6 years, 3 months ago (2014-08-28 15:35:54 UTC) #1
Stephen White
dtu@: PTAL. Thanks!
6 years, 3 months ago (2014-08-28 15:40:33 UTC) #2
tonyg
tonyg@chromium.org changed reviewers: + tonyg@chromium.org
6 years, 3 months ago (2014-08-28 18:41:56 UTC) #3
tonyg
lgtm optional suggestion -- feel free to land either way. https://codereview.chromium.org/514143003/diff/40001/tools/perf/page_sets/tough_filters_cases.py File tools/perf/page_sets/tough_filters_cases.py (right): https://codereview.chromium.org/514143003/diff/40001/tools/perf/page_sets/tough_filters_cases.py#newcode18 ...
6 years, 3 months ago (2014-08-28 18:41:56 UTC) #4
Stephen White
On 2014/08/28 18:41:56, tonyg wrote: > lgtm > > optional suggestion -- feel free to ...
6 years, 3 months ago (2014-08-28 18:43:39 UTC) #5
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 3 months ago (2014-08-28 18:43:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/514143003/40001
6 years, 3 months ago (2014-08-28 18:45:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 19:44:42 UTC) #8
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 19:44:42 UTC) #9
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 3 months ago (2014-08-28 19:57:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/514143003/40001
6 years, 3 months ago (2014-08-28 20:00:23 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:03:09 UTC) #12
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:03:10 UTC) #13
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 3 months ago (2014-08-28 20:08:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/514143003/60001
6 years, 3 months ago (2014-08-28 20:09:33 UTC) #15
Stephen White
Committed patchset #4 (id:60001) to pending queue manually as 2542bcc (presubmit successful).
6 years, 3 months ago (2014-08-28 20:30:53 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:49 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2b2408bc126ca89aac7050c68d1f03259efd7750
Cr-Commit-Position: refs/heads/master@{#292450}

Powered by Google App Engine
This is Rietveld 408576698