components/policy/core/common/cloud/mock_device_management_service.h - Issue 514143002: Manual fixups in components/policy for scoped_refptr operator T* removal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/mock_device_management_service.h

Issue 514143002: Manual fixups in components/policy for scoped_refptr operator T* removal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/cloud/device_management_service.h ('K') | « components/policy/core/common/cloud/device_management_service.cc ('k') | components/policy/core/common/cloud/user_cloud_policy_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/mock_device_management_service.h

diff --git a/components/policy/core/common/cloud/mock_device_management_service.h b/components/policy/core/common/cloud/mock_device_management_service.h

index 83c01de3eb82dec997070ca01761b9890ba82ce3..407046a0c6c913d11e5c6690ca50884c6da3bb98 100644

--- a/components/policy/core/common/cloud/mock_device_management_service.h

+++ b/components/policy/core/common/cloud/mock_device_management_service.h

@@ -47,7 +47,8 @@ class MockDeviceManagementService : public DeviceManagementService {

virtual ~MockDeviceManagementService();

typedef DeviceManagementRequestJob* CreateJobFunction(

- DeviceManagementRequestJob::JobType, net::URLRequestContextGetter*);

+ DeviceManagementRequestJob::JobType,

+ const scoped_refptr<net::URLRequestContextGetter>&);

bartfab (slow) 2014/08/29 09:42:39 Nit: #include "base/memory/ref_counted.h"

dcheng 2014/08/29 09:56:37 Generally I don't #include headers that are alread

bartfab (slow) 2014/08/29 11:18:45 In policy code, we do not include files in a .cc f

MOCK_METHOD2(CreateJob, CreateJobFunction);

MOCK_METHOD7(