components/policy/core/common/cloud/cloud_policy_client_unittest.cc - Issue 514143002: Manual fixups in components/policy for scoped_refptr operator T* removal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_client_unittest.cc

Issue 514143002: Manual fixups in components/policy for scoped_refptr operator T* removal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/cloud/cloud_policy_client.cc ('K') | « components/policy/core/common/cloud/cloud_policy_client.cc ('k') | components/policy/core/common/cloud/device_management_service.h » ('j') | components/policy/core/common/cloud/device_management_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_client_unittest.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc b/components/policy/core/common/cloud/cloud_policy_client_unittest.cc

index e9976048921ece2697114b953a5d96c15235b7fa..1a5c9c80000e42e7bc8379439be4e5a35b7b52b6 100644

--- a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc

+++ b/components/policy/core/common/cloud/cloud_policy_client_unittest.cc

@@ -204,8 +204,8 @@ class CloudPolicyClientTest : public testing::Test {

StrictMock<MockCloudPolicyClientObserver> observer_;

StrictMock<MockUploadCertificateObserver> upload_certificate_observer_;

scoped_ptr<CloudPolicyClient> client_;

- // Cached weak pointer to the client's request context.

- net::URLRequestContextGetter* request_context_;

+ // Pointer to the client's request context.

+ scoped_refptr<net::URLRequestContextGetter> request_context_;

bartfab (slow) 2014/08/29 09:42:38 Nit: #include "base/memory/ref_counted.h"

dcheng 2014/08/29 09:56:37 Done.

};

TEST_F(CloudPolicyClientTest, Init) {