Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 514123005: Make single shell call in _SetScalingGovernorInternal (Closed)

Created:
6 years, 3 months ago by perezju
Modified:
6 years, 3 months ago
Reviewers:
Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make single shell call in _SetScalingGovernorInternal Changed implementation to make a single shell call, rather than pushing files and executing several shell calls. When running telemetry unittests on android, reduces total execution time about 12%. BUG=379378 Committed: https://crrev.com/4bda9f96e6edbc4c208abde787c842f828f2f798 Cr-Commit-Position: refs/heads/master@{#292405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/android/pylib/perf/perf_control.py View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
perezju
perezju@chromium.org changed reviewers: + skyostil@chromium.org
6 years, 3 months ago (2014-08-28 15:51:44 UTC) #1
perezju
6 years, 3 months ago (2014-08-28 15:51:44 UTC) #2
Sami
Nice, the change itself lgtm, but one nit about the changelog message: the first line ...
6 years, 3 months ago (2014-08-28 15:57:44 UTC) #3
perezju
done
6 years, 3 months ago (2014-08-28 16:08:24 UTC) #4
perezju
The CQ bit was checked by perezju@chromium.org
6 years, 3 months ago (2014-08-28 16:08:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perezju@chromium.org/514123005/1
6 years, 3 months ago (2014-08-28 16:09:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1b65bc5728b25e4017d66f88a1987a9f1000971d
6 years, 3 months ago (2014-08-28 17:07:36 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bda9f96e6edbc4c208abde787c842f828f2f798
Cr-Commit-Position: refs/heads/master@{#292405}

Powered by Google App Engine
This is Rietveld 408576698