Manual fixups in compositor code scoped_refptr operator T* removal.

ui/compositor/layer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/layer.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 641 matching lines @@
           sk_damaged.height());
       cc_layer_->SetNeedsDisplayRect(damaged);
     }
     damaged_region_.setEmpty();
   }
   for (size_t i = 0; i < children_.size(); ++i)
     children_[i]->SendDamagedRects();
 }
 
 void Layer::CompleteAllAnimations() {
-  std::vector<scoped_refptr<LayerAnimator> > animators;
+  typedef std::vector<scoped_refptr<LayerAnimator> > LayerAnimatorVector;
+  LayerAnimatorVector animators;
   CollectAnimators(&animators);
-  std::for_each(animators.begin(), animators.end(),
-                std::mem_fun(&LayerAnimator::StopAnimating));

[danakj, 2014/08/28 16:50:42]

isn't mem_fun going to deref the iterator also? why doesn't this work and
(*it)-> does?

[dcheng, 2014/08/28 17:21:18]

I believe mem_fun actually expects a pointer. for_each dereferences the iterator
into a scoped_refptr, but with the conversion operator disabled, no such
conversion is possible.

+  for (LayerAnimatorVector::const_iterator it = animators.begin();
+       it != animators.end();
+       ++it) {
+    (*it)->StopAnimating();
+  }
 }
 
 void Layer::SuppressPaint() {
   if (!delegate_)
     return;
   delegate_ = NULL;
   for (size_t i = 0; i < children_.size(); ++i)
     children_[i]->SuppressPaint();
 }
 
@@ skipping 359 matching lines @@
       children_.end(),
       std::bind2nd(std::mem_fun(&Layer::RemoveAnimatorsInTreeFromCollection),
                    collection));
 }
 
 bool Layer::IsAnimating() const {
   return animator_.get() && animator_->is_animating();
 }
 
 }  // namespace ui