Manual fixups in compositor code scoped_refptr operator T* removal.

cc/resources/tile_manager.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_TILE_MANAGER_H_
 #define CC_RESOURCES_TILE_MANAGER_H_
 
 #include <deque>
 #include <queue>
 #include <set>
@@ skipping 71 matching lines @@
 
 // This class manages tiles, deciding which should get rasterized and which
 // should no longer have any memory assigned to them. Tile objects are "owned"
 // by layers; they automatically register with the manager when they are
 // created, and unregister from the manager when they are deleted.
 class CC_EXPORT TileManager : public RasterizerClient,
                               public RefCountedManager<Tile> {
  public:
   static scoped_ptr<TileManager> Create(
       TileManagerClient* client,
       base::SequencedTaskRunner* task_runner,

[danakj, 2014/08/28 16:50:42]

doesn't this need to be a scoped_refptr too?

[dcheng, 2014/08/28 17:21:18]

I've tried to keep this patch to the bare minimum that was needed to make Chrome
compile with https://codereview.chromium.org/510323002 applied. I'm happy to
address this in a followup, if that's OK.

(Most likely, no one ever passed a temporary scoped_refptr here, which is rare,
since most the ways to get a TaskRunner return a scoped_refptr)

[danakj, 2014/08/28 17:23:55]

This method is what calls the constructor which is now a const scoped_refptr&.
So surely Create is casting this raw pointer to a scoepd_refptr?

[dcheng, 2014/08/28 17:29:00]

It is, but this is "fine" since scoped_refptr is implicitly constructible from
T*.

I do think this should be fixed, but I'd prefer to split it out into a separate
patch--I have a master patch with something like +300/-300 lines that I'm
landing in smaller patches, so minimizing the diffs/conflicts would be helpful
to getting the immediate issue fixed.

       ResourcePool* resource_pool,
       Rasterizer* rasterizer,
       RenderingStatsInstrumentation* rendering_stats_instrumentation);
   virtual ~TileManager();
 
   void ManageTiles(const GlobalStateThatImpactsTilePriority& state);
 
   // Returns true when visible tiles have been initialized.
   bool UpdateVisibleTiles();
 
@@ skipping 49 matching lines @@
   void SetRasterizerForTesting(Rasterizer* rasterizer);
 
   void FreeResourcesAndCleanUpReleasedTilesForTesting() {
     prioritized_tiles_.Clear();
     FreeResourcesForReleasedTiles();
     CleanUpReleasedTiles();
   }
 
  protected:
   TileManager(TileManagerClient* client,
-              base::SequencedTaskRunner* task_runner,
+              const scoped_refptr<base::SequencedTaskRunner>& task_runner,
               ResourcePool* resource_pool,
               Rasterizer* rasterizer,
               RenderingStatsInstrumentation* rendering_stats_instrumentation);
 
   // Methods called by Tile
   friend class Tile;
   void DidChangeTilePriority(Tile* tile);
 
   void FreeResourcesForReleasedTiles();
   void CleanUpReleasedTiles();
@@ skipping 90 matching lines @@
   std::vector<scoped_refptr<RasterTask> > orphan_raster_tasks_;
 
   UniqueNotifier ready_to_activate_check_notifier_;
 
   DISALLOW_COPY_AND_ASSIGN(TileManager);
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_TILE_MANAGER_H_