Issue 514103002: Video Player: Close the video when the session is disconnected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 514103002: Video Player: Close the video when the session is disconnected (Closed)

Created:
6 years, 3 months ago by yoshiki

Modified:
6 years, 3 months ago

Reviewers:
fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Video Player: Close the video when the session is disconnected BUG=403846 TEST=manually tested Committed: https://crrev.com/ad468e8b47617a4f9fb70fecfd9ea320e6f8c1cf Cr-Commit-Position: refs/heads/master@{#292352}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	ui/file_manager/video_player/js/video_player.js	View	1 2 3	4 chunks	+16 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

yoshiki

yoshiki@chromium.org changed reviewers: + fukino@chromium.org

6 years, 3 months ago (2014-08-28 06:47:28 UTC) #1

fukino

On 2014/08/28 06:47:39, yoshiki wrote: > @fukino-san, PTAL. Thanks. lgtm.

6 years, 3 months ago (2014-08-28 07:53:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/514103002/60001

6 years, 3 months ago (2014-08-28 08:08:03 UTC) #5

commit-bot: I haz the power

Committed patchset #4 (id:60001) as fa6928f36404c2648c963b846a573af267676677

6 years, 3 months ago (2014-08-28 09:03:11 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:58:36 UTC) #7

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/ad468e8b47617a4f9fb70fecfd9ea320e6f8c1cf
Cr-Commit-Position: refs/heads/master@{#292352}