Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 514093002: Oilpan: Compile error with GYP_DEFINES='gc_profile_heap=1' (Closed)

Created:
6 years, 3 months ago by Daniel Chow
Modified:
6 years, 3 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: Compile error with GYP_DEFINES='gc_profile_heap=1' 1. change json->setString("name", #HeapType##NonFinalized); to json->setString("name", #HeapType"NonFinalized"); R=ager@chromium.org, oilpan-reviews@chromium.org BUG=408440 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Chow
6 years, 3 months ago (2014-08-28 05:22:23 UTC) #1
haraken
LGTM
6 years, 3 months ago (2014-08-28 05:44:56 UTC) #2
Mads Ager (chromium)
LGTM, thanks.
6 years, 3 months ago (2014-08-28 06:23:52 UTC) #3
Daniel Chow
The CQ bit was checked by zhishun.zhou@samsung.com
6 years, 3 months ago (2014-08-28 06:32:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhishun.zhou@samsung.com/514093002/1
6 years, 3 months ago (2014-08-28 06:32:29 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 08:21:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181017

Powered by Google App Engine
This is Rietveld 408576698