Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 514063002: Revert of [telemetry] Tenatively re-enable IPPET. (Closed)

Created:
6 years, 3 months ago by epennerAtGoogle
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [telemetry] Tenatively re-enable IPPET. (patchset #1 of https://codereview.chromium.org/510143003/) Reason for revert: Reverting since it says to feel free ;) Original issue's description: > [telemetry] Tenatively re-enable IPPET. > > We want to see if it continues to cause flake and noise on the bots. If so, feel free to revert. > > > BUG=336558 > TEST=None. > R=tonyg > > Committed: https://chromium.googlesource.com/chromium/src/+/fad20c0b56b7b1f223cd79fa3a147cbeb5a21575 TBR=tonyg@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG=336558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
epennerAtGoogle
Created Revert of [telemetry] Tenatively re-enable IPPET.
6 years, 3 months ago (2014-08-28 01:35:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@google.com/514063002/1
6 years, 3 months ago (2014-08-28 01:37:08 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:38:03 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:38:04 UTC) #4
dtu
Which bots failed? I didn't see any failures on Windows 8, so I'm going to ...
6 years, 3 months ago (2014-08-28 05:09:59 UTC) #5
epennerAtGoogle
Should have posted some examples, but yeah it was Win7 from what I recall. Looks ...
6 years, 3 months ago (2014-08-28 18:43:15 UTC) #6
epennerAtGoogle
6 years, 3 months ago (2014-08-28 19:29:57 UTC) #7
On 2014/08/28 18:43:15, epennerAtGoogle wrote:
> Should have posted some examples, but yeah it was Win7 from what I recall.
Looks
> like you got it right.

Actually I'm seeing some on Win8 now too:
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%282%29/b...

Powered by Google App Engine
This is Rietveld 408576698