Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 514003002: metrics: Update UpdateEngineErrorCode with new error code. (Closed)

Created:
6 years, 3 months ago by zeuthen
Modified:
6 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

metrics: Update UpdateEngineErrorCode with new error code. We just added a new error code to ChromeOS's update_engine so also update histograms.xml. BUG=chromium:406546 TEST=Validated the xml, pretty print succeeded. Committed: https://crrev.com/caf3405875fe6ed8b97ec027a005d0fde264c7d8 Cr-Commit-Position: refs/heads/master@{#292279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
zeuthen
zeuthen@chromium.org changed reviewers: + asvitkine@chromium.org, cmasone@chromium.org, deymo@chromium.org, isherman@chromium.org, jar@chromium.org, mpearson@chromium.org
6 years, 3 months ago (2014-08-27 21:41:22 UTC) #1
zeuthen
Hi, here's a tiny CL for adding a new error code for ChromeOS's update_engine. Please ...
6 years, 3 months ago (2014-08-27 21:42:03 UTC) #2
Ilya Sherman
LGTM
6 years, 3 months ago (2014-08-27 21:57:11 UTC) #3
zeuthen
The CQ bit was checked by zeuthen@chromium.org
6 years, 3 months ago (2014-08-27 21:59:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeuthen@chromium.org/514003002/1
6 years, 3 months ago (2014-08-27 22:00:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-27 23:10:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as eb74ae3df35c2134778b86f5c1ebb9038ef7954f
6 years, 3 months ago (2014-08-28 00:30:33 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caf3405875fe6ed8b97ec027a005d0fde264c7d8
Cr-Commit-Position: refs/heads/master@{#292279}

Powered by Google App Engine
This is Rietveld 408576698