Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 513933003: NaCl: Update revision in DEPS, r13666 -> r13668 (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 3 months ago
Reviewers:
bradnelson
CC:
chromium-reviews, native-client-reviews_googlegroups.com, noelallen_use_chromium, Yoshisato Yanagisawa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13666 -> r13668 This pulls in the following Native Client changes: r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain r13668: (noelallen) Force rebuild on cmd change. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build TBR=bradnelson@chromium.org Committed: https://crrev.com/87177293362d72095124674372e27ac259d60803 Cr-Commit-Position: refs/heads/master@{#292383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Mark Seaborn
mseaborn@chromium.org changed reviewers: + bradnelson@chromium.org
6 years, 3 months ago (2014-08-28 04:57:42 UTC) #1
Mark Seaborn
6 years, 3 months ago (2014-08-28 04:58:03 UTC) #2
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 3 months ago (2014-08-28 04:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/513933003/1
6 years, 3 months ago (2014-08-28 04:59:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 05:41:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 06:03:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/588)
6 years, 3 months ago (2014-08-28 06:03:23 UTC) #7
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 3 months ago (2014-08-28 14:57:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/513933003/1
6 years, 3 months ago (2014-08-28 14:57:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as ba2092ce9ac0792098dcca59f9a224e13825dcd5
6 years, 3 months ago (2014-08-28 15:19:30 UTC) #10
tim (not reviewing)
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/509413002/ by tim@chromium.org. The ...
6 years, 3 months ago (2014-08-28 17:36:24 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87177293362d72095124674372e27ac259d60803
Cr-Commit-Position: refs/heads/master@{#292383}

Powered by Google App Engine
This is Rietveld 408576698