Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 513923005: More PNaCL fixes. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

More PNaCL fixes.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -58 lines) Patch
M Makefile.nacl View 2 chunks +12 lines, -23 lines 0 comments Download
M src/base/platform/platform-linux.cc View 5 chunks +21 lines, -9 lines 0 comments Download
M src/base/platform/platform-posix.cc View 4 chunks +15 lines, -8 lines 0 comments Download
M src/base/platform/semaphore.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/base/sys-info.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/d8-posix.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M src/sampler.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sven Panne
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-28 12:29:20 UTC) #1
Sven Panne
Patchset #1 (id:20001) has been deleted
6 years, 3 months ago (2014-08-28 12:29:31 UTC) #2
Sven Panne
Patchset #1 (id:40001) has been deleted
6 years, 3 months ago (2014-08-28 12:39:49 UTC) #3
Sven Panne
svenpanne@chromium.org changed reviewers: + bmeurer@chromium.org
6 years, 3 months ago (2014-08-28 13:49:02 UTC) #4
Sven Panne
There are still some obscure linker errors for 64bit div/mod operations, but please PTAL nevertheless...
6 years, 3 months ago (2014-08-28 13:49:02 UTC) #5
Sven Panne
On 2014/08/28 13:49:02, Sven Panne wrote: > There are still some obscure linker errors for ...
6 years, 3 months ago (2014-08-28 13:50:15 UTC) #6
Sven Panne
Patchset #1 (id:60001) has been deleted
6 years, 3 months ago (2014-08-28 14:06:41 UTC) #7
Sven Panne
Patchset #1 (id:80001) has been deleted
6 years, 3 months ago (2014-08-28 14:07:18 UTC) #8
Benedikt Meurer
6 years, 3 months ago (2014-08-29 04:50:40 UTC) #9
Ugly, but LGTM

Powered by Google App Engine
This is Rietveld 408576698