Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 513923004: More viewmanager renaming: (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

More viewmanager renaming: . RootNodeManager->ConnectionManager. A better name might be ViewManagerServiceImplsManager, but I can't come to type that in. . Node->ServerView. I really want to use View, but having a class named View in the server and lib has confused everyone I've talked to and makes talking about View extremely abiguous. BUG=none TEST=none R=jamesr@chromium.org Committed: https://crrev.com/c6e218340f4ad2e8264cc9cc37f2556825ffd4b8 Cr-Commit-Position: refs/heads/master@{#292311}

Patch Set 1 #

Patch Set 2 : nuke ShouldSendViewDeleted #

Patch Set 3 : comment #

Patch Set 4 : sim30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1182 lines, -1927 lines) Patch
M mojo/mojo_services.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/view_manager/access_policy.h View 1 2 chunks +21 lines, -23 lines 0 comments Download
M mojo/services/view_manager/access_policy_delegate.h View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/services/view_manager/connection_manager.h View 10 chunks +49 lines, -49 lines 0 comments Download
A + mojo/services/view_manager/connection_manager.cc View 7 chunks +85 lines, -76 lines 0 comments Download
M mojo/services/view_manager/default_access_policy.h View 1 1 chunk +17 lines, -16 lines 0 comments Download
M mojo/services/view_manager/default_access_policy.cc View 1 2 chunks +44 lines, -46 lines 0 comments Download
M mojo/services/view_manager/display_manager.h View 2 chunks +10 lines, -10 lines 0 comments Download
M mojo/services/view_manager/display_manager.cc View 10 chunks +27 lines, -25 lines 0 comments Download
M mojo/services/view_manager/ids.h View 3 chunks +5 lines, -34 lines 0 comments Download
D mojo/services/view_manager/node.h View 1 chunk +0 lines, -82 lines 0 comments Download
D mojo/services/view_manager/node.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D mojo/services/view_manager/node_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/services/view_manager/root_node_manager.h View 1 chunk +0 lines, -210 lines 0 comments Download
D mojo/services/view_manager/root_node_manager.cc View 1 chunk +0 lines, -268 lines 0 comments Download
A + mojo/services/view_manager/server_view.h View 1 2 3 3 chunks +35 lines, -31 lines 0 comments Download
A + mojo/services/view_manager/server_view.cc View 4 chunks +33 lines, -34 lines 0 comments Download
A + mojo/services/view_manager/server_view_delegate.h View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 4 chunks +18 lines, -18 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 5 chunks +53 lines, -55 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 8 chunks +66 lines, -61 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 18 chunks +232 lines, -228 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 13 chunks +392 lines, -387 lines 0 comments Download
M mojo/services/view_manager/window_manager_access_policy.h View 1 1 chunk +17 lines, -16 lines 0 comments Download
M mojo/services/view_manager/window_manager_access_policy.cc View 1 2 chunks +33 lines, -37 lines 0 comments Download
M mojo/services/view_manager/window_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 3 months ago (2014-08-27 21:53:50 UTC) #1
jamesr
Seem reasonable, lgtm
6 years, 3 months ago (2014-08-27 22:58:59 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 3 months ago (2014-08-27 23:01:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/513923004/60001
6 years, 3 months ago (2014-08-27 23:02:38 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001) as f62c401ae5700ee8bcdfeebb5ec038bae76691f1
6 years, 3 months ago (2014-08-28 03:45:34 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:09 UTC) #6
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c6e218340f4ad2e8264cc9cc37f2556825ffd4b8
Cr-Commit-Position: refs/heads/master@{#292311}

Powered by Google App Engine
This is Rietveld 408576698