Fix enable a11y tests for History and fix failures

chrome/browser/resources/history/history.js

Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index 4a16a5233177632a1667b6d7381d7f02aeb2517f..85f84f216a8ec900cb1e2804c8cdaf59768366ac 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -1292,6 +1292,7 @@ HistoryView.prototype.getGroupedVisitsDOM_ = function(
     siteDomainCheckbox.type = 'checkbox';
     siteDomainCheckbox.addEventListener('click', domainCheckboxClicked);
     siteDomainCheckbox.domain_ = domain;
+    siteDomainCheckbox.setAttribute('aria-label', domain);
     siteDomainRow.appendChild(siteDomainCheckbox);
   }
 
@@ -1327,6 +1328,7 @@ HistoryView.prototype.getGroupedVisitsDOM_ = function(
 
   // Collapse until it gets toggled.
   resultsList.style.height = 0;

[aboxhall, 2014/08/28 15:21:41]

Any reason not to just set this to display: none? Would it cause weirdness when
re-showing it? (display: none will hide it from a11y as well, so you wouldn't
need aria-hidden.)

[hcarmona, 2014/09/03 20:49:34]

When I changed this to display: none, the collapse animations disappeared. It
may need to stay as aria-hidden to avoid breaking the collapse effect on the
list.


On 2014/08/28 15:21:41, aboxhall_ooo_until_oct_6 wrote:

+  resultsList.setAttribute('aria-hidden', 'true');
 
   // Add the results for each of the domain.
   var isMonthGroupedResult = this.getRangeInDays() == HistoryModel.Range.MONTH;
@@ -1681,7 +1683,9 @@ HistoryView.prototype.toggleGroupedVisits_ = function(e) {
 
   if (entry.classList.contains('expand')) {
     innerResultList.style.height = 0;
+    innerResultList.setAttribute('aria-hidden', 'true');
   } else {
+    innerResultList.setAttribute('aria-hidden', 'false');
     innerResultList.style.height = 'auto';
     // -webkit-transition does not work on height:auto elements so first set
     // the height to auto so that it is computed and then set it to the