Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 513903002: cc: Always remove tiles from the recycle tree also. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Always remove tiles from the recycle tree also. Currently only one site that deletes a tile removes it from the recycle twin. Change the others to also, or DCHECK showing they don't need to. R=enne, vmpstr Committed: https://crrev.com/e8c25475f7b45679a7562449f11fb3afa71ec8d7 Cr-Commit-Position: refs/heads/master@{#292265}

Patch Set 1 #

Patch Set 2 : recycle: test #

Patch Set 3 : recycle: fixdcheck #

Patch Set 4 : recycle: pushprops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -87 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 2 4 chunks +27 lines, -29 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 2 chunks +109 lines, -53 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
danakj
This is the changes to RemoveTilesAt stuff from https://codereview.chromium.org/505913003/ I can rebase away these changes ...
6 years, 3 months ago (2014-08-27 18:14:36 UTC) #1
danakj
In this patch the missing call-side is just Reset(), but I'll be adding more callers ...
6 years, 3 months ago (2014-08-27 18:18:05 UTC) #2
danakj
Now with a test for Reset()
6 years, 3 months ago (2014-08-27 18:32:29 UTC) #3
danakj
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-27 18:32:54 UTC) #4
danakj
I ported the GetTree DCHECK over to this CL. Do you think this is worth ...
6 years, 3 months ago (2014-08-27 19:47:05 UTC) #5
vmpstr
lgtm, I guess this goes first and the crash fix depends on it?
6 years, 3 months ago (2014-08-27 22:31:47 UTC) #6
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 3 months ago (2014-08-27 22:32:02 UTC) #7
danakj
Thanks! Yep
6 years, 3 months ago (2014-08-27 22:32:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/513903002/80001
6 years, 3 months ago (2014-08-27 22:34:29 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 23:05:40 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:29:07 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:29:08 UTC) #12
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 3 months ago (2014-08-27 23:30:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/513903002/80001
6 years, 3 months ago (2014-08-27 23:32:28 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001) as af87dd02afe92b667998c7271fda2660964dc46a
6 years, 3 months ago (2014-08-27 23:35:00 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:32 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e8c25475f7b45679a7562449f11fb3afa71ec8d7
Cr-Commit-Position: refs/heads/master@{#292265}

Powered by Google App Engine
This is Rietveld 408576698